feat(ivy): add ability to inspect local refs through context discovery #26117
Conversation
|
You can preview f797bd5 at https://pr26117-f797bd5.ngbuilds.io/. |
| selectors: [['comp']], | ||
| factory: () => new Comp(), | ||
| consts: 1, | ||
| vars: 1, |
There was a problem hiding this comment.
I think this should be 3 consts and 0 vars, no?
| for (let i = 0; i < tNode.localNames.length; i += 2) { | ||
| const localRefName = tNode.localNames[i]; | ||
| const directiveIndex = tNode.localNames[i + 1] as number; | ||
| result[localRefName] = directiveIndex === -1 ? lViewData[lNodeIndex].native : |
There was a problem hiding this comment.
I think we want to wrap lViewData[lNodeIndex] with readElementValue in case that element happens to have a styling context. You might want to use getLNode(), since it has that built in. (Maybe a test for this?)
| const localRefName = tNode.localNames[i]; | ||
| const directiveIndex = tNode.localNames[i + 1] as number; | ||
| result[localRefName] = directiveIndex === -1 ? lViewData[lNodeIndex].native : | ||
| lViewData[DIRECTIVES] ![directiveIndex]; |
There was a problem hiding this comment.
What about local refs on ng-template elements? Is that something we want to support?
There was a problem hiding this comment.
Right. I don't need it for TestBed but we should add it for completeness + a test. Thnx for catching this!
There was a problem hiding this comment.
FWIW, if it's not necessary for TestBed, we could probably just make a JIRA ticket for later. Was just curious what your thoughts were on supporting it down the line.
| directives: Array<{}>|null|undefined; | ||
| directives: any[]|null|undefined; | ||
|
|
||
| /** The map of local references (local reference name => element or directive instance) that exist |
There was a problem hiding this comment.
nit: /** should not have text after it. (insert line break).
43bd538 to
725b4a3
Compare
|
You can preview 43bd538 at https://pr26117-43bd538.ngbuilds.io/. |
|
You can preview 725b4a3 at https://pr26117-725b4a3.ngbuilds.io/. |
725b4a3 to
fa0ec85
Compare
|
You can preview fa0ec85 at https://pr26117-fa0ec85.ngbuilds.io/. |
|
Marking as merge-assistance since:
|
fa0ec85 to
8f522ba
Compare
|
You can preview 8f522ba at https://pr26117-8f522ba.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is needed for the TestBed implementation since we can ask for a set of local refs on a given debug element.