fix(ivy): remove debug utilities from ivy production builds #30130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
800c0dd to
383c823
Compare
b10aca4 to
73ac93f
Compare
mhevery
approved these changes
Apr 26, 2019
Prior to this commit, we were pulling DebugNode and DebugElement into production builds because BrowserModule automatically pulled in NgProbe and thus getDebugNode. In Ivy, this is not necessary because Ivy has its own set of debug utilities. We should use these existing tools instead of NgProbe. This commit adds an Ivy switch so we do not pull in NgProbe utilities when running with Ivy. This saves us ~8KB in prod builds.
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 26, 2019
Prior to this commit, we were pulling DebugNode and DebugElement into production builds because BrowserModule automatically pulled in NgProbe and thus getDebugNode. In Ivy, this is not necessary because Ivy has its own set of debug utilities. We should use these existing tools instead of NgProbe. This commit adds an Ivy switch so we do not pull in NgProbe utilities when running with Ivy. This saves us ~8KB in prod builds. PR Close #30130
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…30130) Prior to this commit, we were pulling DebugNode and DebugElement into production builds because BrowserModule automatically pulled in NgProbe and thus getDebugNode. In Ivy, this is not necessary because Ivy has its own set of debug utilities. We should use these existing tools instead of NgProbe. This commit adds an Ivy switch so we do not pull in NgProbe utilities when running with Ivy. This saves us ~8KB in prod builds. PR Close angular#30130
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we were pulling DebugNode and DebugElement
into production builds because BrowserModule automatically pulled
in NgProbe and thus getDebugNode. In Ivy, this is not necessary
because Ivy has its own set of debug utilities. We should use these
existing tools instead of NgProbe.
This commit adds an Ivy switch so we do not pull in NgProbe utilities
when running with Ivy. This saves us ~8KB in prod builds.
Note: Master is red for unrelated size regressions :-(