refactor(core): clean up support for ES2015 constructor delegation #30368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the delegated constructor detection to a helper function and also adds more test coverage. The original code for this came from angular#24156 thanks to @ts2do. Closes angular#24156 Closes angular#27267 // FW-1310
14 tasks
alxhub
approved these changes
May 9, 2019
|
Kudos for adding the missing tests Pete. |
|
The kudos should really go to @ts2do |
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ngular#30368) This commit moves the delegated constructor detection to a helper function and also adds more test coverage. The original code for this came from angular#24156 thanks to @ts2do. Closes angular#24156 Closes angular#27267 // FW-1310 PR Close angular#30368
|
Is this released in Angular 8? |
|
Yes it is in 8.1.0 and onwards. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the delegated constructor detection to a helper
function and also adds more test coverage.
The original code for this came from #24156
thanks to @ts2do.
Closes #24156
Closes #27267
// FW-1310