Skip to content

build: fix @bazel/bazel to bazelisk leftovers #36132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: fix @bazel/bazel to bazelisk leftovers #36132

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

@devversion devversion commented Mar 18, 2020 •
edited
Loading

Follow-up for #36078. A few leftovers from from @bazel/bazel to
@bazel/bazelisk migration are still there. This commit fixes those, so
that the repository no longer relies on @bazel/bazel.

@devversion
build: fix @bazel/bazel to bazelisk leftovers
d588761 
A few leftovers from from `@bazel/bazel` to `@bazel/bazelisk` migration
are still there. This commit fixes those, so that the repository no
longer relies on `@bazel/bazel`.
@pullapprove pullapprove bot requested a review from IgorMinar March 18, 2020 21:41
@devversion devversion added area: build & ci Related the build and CI infrastructure of the project action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 18, 2020
@ngbot ngbot bot modified the milestone: needsTriage Mar 18, 2020
devversion
devversion commented Mar 18, 2020
View reviewed changes
scripts/release/publish-latest
# through `yarn bazel` causes additional output that throws off the command stdout.
BAZEL_BIN=$(yarn bin)/bazel
# through `yarn bazelisk` causes additional output that throws off the command stdout.
BAZEL_BIN=$(yarn bin)/bazelisk
Copy link
Member Author

@devversion devversion Mar 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered switching this to yarn --silent bazel (to fix the stdout capturing and to consistently use yarn bazel), but decided to keep it as is.

Mostly because bazel query <..> kind("ng_package|pkg_npm", //packages/...) breaks on Windows unexpectedly with yarn --silent bazel.

josephperrott
josephperrott approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott removed the request for review from IgorMinar March 19, 2020 14:00
@AndrewKushnir
Copy link
Contributor

Hi @IgorMinar, as we discussed yesterday, you had some feedback about the changes in this PR (related to using yarn with bazelisk), but in order to get release unblocked, I've merged this PR in its current state. Let's create a followup PR once you provide the feedback. Thank you.

@devversion
Copy link
Member Author

👍 Sounds good to me. Would love to get feedback on this. Note that I replied on why I intentionally didn't use yarn bazel (if that is related to the discussion you had yesterday)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@IgorMinar IgorMinar

Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @AndrewKushnir @josephperrott @IgorMinar @googlebot