perf(core): use ngDevMode to tree-shake checkNoChanges
#39964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arturovt, thanks for creating PRs to improve tree-shaking 👍 I'd like to propose an idea to group all commits from other PRs (except the one that is already marked for merge) into a single PR (while keeping changes in separate commits). That should help review these changes as a whole and would simplify the process of landing these changes. Thank you. |
|
@arturovt another benefit is that you may need to update payload sizes for test/demo apps (reducing the size), so there might be code conflicts that you would need to resolve multiple times... |
Yeah that makes sense. I was just thinking that it's a bad idea to have changes, that affect different packages, in 1 PR. |
This commit adds `ngDevMode` guard to run `checkNoChanges` only in dev mode (similar to how things work in other parts of Ivy runtime code). The `ngDevMode` flag helps to tree-shake this code from production builds (in dev mode everything will work as it works right now) to decrease production bundle size.
This commit adds ngDevMode guard to show warnings only in dev mode (similar to how things work in other parts of Ivy runtime code). The ngDevMode flag helps to tree-shake these warnings from production builds (in dev mode everything will work as it works right now) to decrease production bundle size.
This commit adds ngDevMode guard to show warning only in dev mode (similar to how things work in other parts of Ivy runtime code). The ngDevMode flag helps to tree-shake this warning from production builds (in dev mode everything will work as it works right now) to decrease production bundle size.
This commit adds `ngDevMode` guard to call `_ngModelWarning` only in dev mode (similar to how things work in other parts of Ivy runtime code). The `ngDevMode` flag helps to tree-shake this function from production builds (since it will act as no-op, in dev mode everything will work as it works right now) to decrease production bundle size.
AndrewKushnir
requested changes
Dec 4, 2020
There was a problem hiding this comment.
Thanks for grouping commits into a single PR @arturovt 👍
The changes look good, just left a comment were I believe we'd still need to use isDevMode() check. Could you please have a look when you get a chance?
AndrewKushnir
approved these changes
Dec 4, 2020
mhevery
approved these changes
Dec 5, 2020
mhevery
pushed a commit
that referenced
this pull request
Dec 5, 2020
This commit adds ngDevMode guard to show warnings only in dev mode (similar to how things work in other parts of Ivy runtime code). The ngDevMode flag helps to tree-shake these warnings from production builds (in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
mhevery
pushed a commit
that referenced
this pull request
Dec 5, 2020
This commit adds ngDevMode guard to show warning only in dev mode (similar to how things work in other parts of Ivy runtime code). The ngDevMode flag helps to tree-shake this warning from production builds (in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
mhevery
pushed a commit
that referenced
this pull request
Dec 5, 2020
This commit adds `ngDevMode` guard to call `_ngModelWarning` only in dev mode (similar to how things work in other parts of Ivy runtime code). The `ngDevMode` flag helps to tree-shake this function from production builds (since it will act as no-op, in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
mhevery
pushed a commit
that referenced
this pull request
Dec 5, 2020
This commit adds `ngDevMode` guard to run `checkNoChanges` only in dev mode (similar to how things work in other parts of Ivy runtime code). The `ngDevMode` flag helps to tree-shake this code from production builds (in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
mhevery
pushed a commit
that referenced
this pull request
Dec 5, 2020
This commit adds ngDevMode guard to show warnings only in dev mode (similar to how things work in other parts of Ivy runtime code). The ngDevMode flag helps to tree-shake these warnings from production builds (in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
mhevery
pushed a commit
that referenced
this pull request
Dec 5, 2020
This commit adds ngDevMode guard to show warning only in dev mode (similar to how things work in other parts of Ivy runtime code). The ngDevMode flag helps to tree-shake this warning from production builds (in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
mhevery
pushed a commit
that referenced
this pull request
Dec 5, 2020
This commit adds `ngDevMode` guard to call `_ngModelWarning` only in dev mode (similar to how things work in other parts of Ivy runtime code). The `ngDevMode` flag helps to tree-shake this function from production builds (since it will act as no-op, in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Dec 5, 2020
…#39964) This commit adds `ngDevMode` guard to call `_ngModelWarning` only in dev mode (similar to how things work in other parts of Ivy runtime code). The `ngDevMode` flag helps to tree-shake this function from production builds (since it will act as no-op, in dev mode everything will work as it works right now) to decrease production bundle size. PR Close angular#39964
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Does this PR introduce a breaking change?