Skip to content

fix(core): set ngDevMode to false when calling enableProdMode() #40159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(core): set ngDevMode to false when calling enableProdMode() #40159

wants to merge 2 commits into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Dec 16, 2020

The ngDevMode description also mentions that calling enableProdMode will set this the value to false.

angular/packages/core/src/util/ng_dev_mode.ts

Line 22 in 4610093

* - The user calls `enableProdMode()`.
which is currently not the case.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 @kyliau
fix(core): set ngDevMode to false when calling enableProdMode()
2e7084f 
The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.
@google-cla
Copy link

google-cla bot commented Dec 16, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 16, 2020
@pullapprove pullapprove bot requested a review from mhevery December 16, 2020 21:06
@kyliau kyliau added the target: lts This PR is targeting a version currently in long-term support label Dec 16, 2020
@kyliau kyliau mentioned this pull request Dec 16, 2020
Closed
@kyliau kyliau added cla: yes and removed cla: no labels Dec 16, 2020
@google-cla
Copy link

google-cla bot commented Dec 16, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Dec 16, 2020
@kyliau kyliau added cla: yes and removed cla: no labels Dec 16, 2020
@kyliau
build: upgrade typescript (dev dep) in zone.js to 3.8.3
630eedd 
Upgrade the typescript dev dependency in packages/zone.js to 3.8.3.
This make it consistent with the version specified in root package.json.
@google-cla
Copy link

google-cla bot commented Dec 16, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Dec 16, 2020
@kyliau kyliau added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note cla: yes and removed cla: no labels Dec 16, 2020
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Dec 16, 2020
@ngbot
Copy link

ngbot bot commented Dec 16, 2020

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing
    pending status "ci/angular: size" is pending
    pending status "ci/circleci: aio_preview" is pending
    pending status "ci/circleci: build-ivy-npm-packages" is pending
    pending status "ci/circleci: components-repo-unit-tests" is pending
    pending status "ci/circleci: legacy-unit-tests-saucelabs" is pending
    pending status "ci/circleci: publish_packages_as_artifacts" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: test_aio" is pending
    pending status "ci/circleci: test_aio_local" is pending
    pending status "ci/circleci: test_aio_local_viewengine" is pending
    pending status "ci/circleci: test_aio_tools" is pending
    pending status "ci/circleci: test_docs_examples" is pending
    pending status "ci/circleci: test_docs_examples_viewengine" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alxhub
Copy link
Member

alxhub commented Dec 16, 2020

Closed by commit 9ae216c

@alxhub alxhub closed this Dec 16, 2020
alxhub pushed a commit that referenced this pull request Dec 16, 2020
@alan-agius4 @alxhub
fix(core): set ngDevMode to false when calling enableProdMode() (…
c3942e4 
…#40159)

The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`.
https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.

PR Close #40159
alxhub pushed a commit that referenced this pull request Dec 16, 2020
@kyliau @alxhub
build: upgrade typescript (dev dep) in zone.js to 3.8.3 (#40159)
9ae216c 
Upgrade the typescript dev dependency in packages/zone.js to 3.8.3.
This make it consistent with the version specified in root package.json.

PR Close #40159
@kyliau kyliau deleted the 9.1.x branch December 16, 2020 22:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyliau @alxhub @mhevery @alan-agius4