Skip to content

docs: fix release notes for v14.0.0 - remove notice "fixes 45350" from breaking changes #46238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: fix release notes for v14.0.0 - remove notice "fixes 45350" from breaking changes #46238

wants to merge 1 commit into from

Conversation

Platonn
Copy link
Contributor

@Platonn Platonn commented Jun 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from devversion June 3, 2022 10:00
@Platonn Platonn mentioned this pull request Jun 3, 2022
Closed
gkalpak
gkalpak reviewed Jun 3, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -134,7 +134,7 @@
callback was executed for the first time. Now it's tracked until
the task is explicitly cancelled, e.g with `clearInterval(id)`.

fixes 45350
fixes [#45350](https://github.com/angular/angular/pull/45350)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The canonical URL is .../issues/... (although the current URL redirects to that).

Suggested change
fixes [#45350](https://github.com/angular/angular/pull/45350)
fixes [#45350](https://github.com/angular/angular/issues/45350)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this Fixes ... reference should not be part of the breaking change notice. (It failed to be recognized and removed by our tooling due to missing the # before the issue number.)

Could you please remove this line altogether?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gkalpak for review!
I removed the notice fixes.... I also updated the commit message and PR title.

@Platonn Platonn changed the title docs: fix release notes for v14.0.0 - fix link to #45350 docs: fix release notes for v14.0.0 - remove notice "fixes 45350" Jun 3, 2022
@Platonn Platonn changed the title docs: fix release notes for v14.0.0 - remove notice "fixes 45350" docs: fix release notes for v14.0.0 - remove notice "fixes 45350" from breaking changes Jun 3, 2022
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker comp: docs target: patch This PR is targeted for the next patch release labels Jun 3, 2022
@ngbot ngbot bot modified the milestone: Backlog Jun 3, 2022
@alxhub
Copy link
Member

alxhub commented Jun 3, 2022

This PR was merged into the repository by commit da0f53b.

@alxhub alxhub closed this in da0f53b Jun 3, 2022
alxhub pushed a commit that referenced this pull request Jun 3, 2022
@Platonn @alxhub
docs: fix release notes for v14.0.0 - remove notice "fixes 45350" fro…
0cc2b89 
…m breaking changes (#46238)

PR Close #46238
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@Platonn @alxhub @devversion @gkalpak @AndrewKushnir