-
Notifications
You must be signed in to change notification settings - Fork 26.5k
docs(router): document segment consumption during route evaluation #58069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(router): document segment consumption during route evaluation #58069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nesjett thanks for improving Angular docs!
Caretaker note: no presubmit is required, docs-only change. |
Note: adding cleanup label. Lint seems to be failing. |
Do I need to do anything? The command that failed seem to modify the file but not changing anything at all. (maybe some EOF or something?)
I can update the PR with that change, but what commit message should I use, chore? It does not seem to fit any of the listed in the "contributing" docs: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit |
Hmm. Maybe you are not rebased? CI runs with a rebased version |
I the script ran on the branch of the PR, it updates and fixes the file without a rebase (by removing a trailing space). |
Caretaker note: no presubmit is required, docs-only change. |
This PR was merged into the repository by commit 18ddf0d. The changes were merged into the following branches: main, 18.2.x, 19.0.x |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This PR was previously closed because of inactivity. Let me know if this is not the right way of resending it, but otherwise, which commit message should I have set on the correction?
Original PR: #57437