Skip to content

fix(localize): Adding arb format to the list of valid formats in the… #58287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(localize): Adding arb format to the list of valid formats in the… #58287

wants to merge 1 commit into from

Conversation

danielpayetdev
Copy link
Contributor

… localization extractor cli

Although the ARB format is supported, it's missing from the command's list of options.

Fix #58286

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #58286

What is the new behavior?

Support arb format in extract localize cli

Does this PR introduce a breaking change?

  • Yes
  • No

@danielpayetdev
fix(localize): Adding arb format to the list of valid formats in the …
a1a91c7 
…localization extractor cli

Although the ARB format is supported, it's missing from the command's list of options.

Fix angular#58286
@pullapprove pullapprove bot requested a review from AndrewKushnir October 21, 2024 17:42
@AndrewKushnir AndrewKushnir requested a review from clydin October 22, 2024 23:48
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n Issues related to localization and internationalization target: minor This PR is targeted for the next minor release labels Oct 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 22, 2024
alan-agius4
alan-agius4 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 removed the request for review from clydin October 23, 2024 05:33
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Oct 23, 2024
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 23, 2024
@alxhub
Copy link
Member

alxhub commented Oct 24, 2024

This PR was merged into the repository by commit d16a609.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

@alxhub alxhub closed this in d16a609 Oct 24, 2024
alxhub pushed a commit that referenced this pull request Oct 24, 2024
@danielpayetdev @alxhub
fix(localize): Adding arb format to the list of valid formats in the …
3b989ac 
…localization extractor cli (#58287)

Although the ARB format is supported, it's missing from the command's list of options.

Fix #58286

PR Close #58287
alxhub pushed a commit that referenced this pull request Oct 24, 2024
@danielpayetdev @alxhub
fix(localize): Adding arb format to the list of valid formats in the …
0730d9d 
…localization extractor cli (#58287)

Although the ARB format is supported, it's missing from the command's list of options.

Fix #58286

PR Close #58287
@danielpayetdev danielpayetdev deleted the add-arb-to-extract-cli branch October 25, 2024 04:31
@davidjbradshaw davidjbradshaw mentioned this pull request Nov 2, 2024
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

@clydin clydin clydin approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

arb format is missing from cli option of extract tool
5 participants
@danielpayetdev @alxhub @alan-agius4 @clydin @AndrewKushnir