Skip to content

refactor(core): remove globalApi tag #58375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): remove globalApi tag #58375

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@globalApi was an AIO implementation detail that isn't relevant anymore.

@crisbeto
refactor(core): remove globalApi tag
153bde9 
`@globalApi` was an AIO implementation detail that isn't relevant anymore.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 26, 2024
@pullapprove pullapprove bot requested a review from dgp1130 October 26, 2024 07:08
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Oct 26, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 26, 2024
JeanMeche
JeanMeche approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we don't use that anymore.

dgp1130
dgp1130 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: fw-i18n

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 28, 2024
@crisbeto crisbeto removed the target: major This PR is targeted for the next major release label Oct 28, 2024
@alxhub
Copy link
Member

alxhub commented Oct 28, 2024

This PR was merged into the repository by commit 61203d1.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

alxhub pushed a commit that referenced this pull request Oct 28, 2024
@crisbeto @alxhub
refactor(core): remove globalApi tag (#58375)
ddda355 
`@globalApi` was an AIO implementation detail that isn't relevant anymore.

PR Close #58375
alxhub pushed a commit that referenced this pull request Oct 28, 2024
@crisbeto @alxhub
refactor(core): remove globalApi tag (#58375)
ad3fbe6 
`@globalApi` was an AIO implementation detail that isn't relevant anymore.

PR Close #58375
@alxhub alxhub closed this in 61203d1 Oct 28, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@dgp1130 dgp1130 dgp1130 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @alxhub @JeanMeche @dgp1130