Skip to content

docs: fix backtick escaping in a Markdown file #58387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: fix backtick escaping in a Markdown file #58387

wants to merge 1 commit into from

Conversation

looshch
Copy link
Contributor

@looshch looshch commented Oct 28, 2024

Fix backtick escaping for the template string example in the documentation on expression syntax.

Closes #58382

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

there is an incorrect backtick escaping in the section about unsupported literals the documentation on expression syntax (highlighted on the first screenshot and without highlighting on the second one)

Image
Image

Issue Number: #58382

What is the new behavior?

the syntax is highlighted correctly

highlighted with a cursor
Screenshot 2024-10-27 at 7 13 30 PM

without cursor highlighting
Screenshot 2024-10-27 at 7 13 14 PM

Does this PR introduce a breaking change?

  • Yes
  • No

@looshch
docs: fix backtick escaping in a Markdown file
6602f57 
Fix backtick escaping for the template string example in the
documentation on expression syntax.

Closes #58382

PR Close #58387
@pullapprove pullapprove bot requested a review from crisbeto October 28, 2024 11:40
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 28, 2024
@looshch looshch mentioned this pull request Oct 28, 2024
Closed
14 tasks
JeanMeche
JeanMeche approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

@JeanMeche JeanMeche removed the request for review from crisbeto October 28, 2024 17:43
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 28, 2024
@alxhub
Copy link
Member

alxhub commented Oct 28, 2024

This PR was merged into the repository by commit 92fbecb.

The changes were merged into the following branches: main, 18.2.x, 19.0.x

alxhub pushed a commit that referenced this pull request Oct 28, 2024
@looshch @alxhub
docs: fix backtick escaping in a Markdown file (#58387)
c6a21cc 
Fix backtick escaping for the template string example in the
documentation on expression syntax.

Closes #58382

PR Close #58387

PR Close #58387
@alxhub alxhub closed this in 92fbecb Oct 28, 2024
alxhub pushed a commit that referenced this pull request Oct 28, 2024
@looshch @alxhub
docs: fix backtick escaping in a Markdown file (#58387)
7d67bd3 
Fix backtick escaping for the template string example in the
documentation on expression syntax.

Closes #58382

PR Close #58387

PR Close #58387
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

incorrect backtick escaping in the documentation on expression syntax
3 participants
@looshch @alxhub @JeanMeche