refactor(docs-infra): AppComponent cleanups #58897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed adev-preview for 83be44d to: https://ng-dev-previews-fw--pr-angular-angular-58897-adev-prev-nzpfri2s.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
72cc671 to
18d7882
Compare
JeanMeche
reviewed
Nov 26, 2024
JeanMeche
reviewed
Nov 26, 2024
This change contains multiple cleanups in the AppComponent: - remove unused code; - use router input bindings instead of manual read from the active route; - remove isBrowser checks from even handlers (click events should not be invoked on the server, right?)
18d7882 to
83be44d
Compare
JeanMeche
approved these changes
Mar 4, 2025
|
This PR was merged into the repository by commit 30ede6b. The changes were merged into the following branches: main, 19.2.x |
mmalerba
pushed a commit
that referenced
this pull request
Mar 4, 2025
This change contains multiple cleanups in the AppComponent: - remove unused code; - use router input bindings instead of manual read from the active route; - remove isBrowser checks from even handlers (click events should not be invoked on the server, right?) PR Close #58897
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Mar 5, 2025
crisbeto
pushed a commit
that referenced
this pull request
Mar 5, 2025
crisbeto
pushed a commit
that referenced
this pull request
Mar 5, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains multiple cleanups in the AppComponent: