fix(common): remove placeholder image listeners once view is removed #61621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Prior to this commit, attempting to resolve a ChangeDetectorRef after views or app have been destroyed would result in an error.
@arturovt could you please provide a bit more info on this - when does it happen? I'm also wondering it it might be possible to have a test to capture this behavior?
|
The most basic showcase: // server.ts
app.get('/cat-blurred.jpg', async (req, res) => {
await new Promise((resolve) => setTimeout(resolve, 4000));
res.sendFile('/cat-blurred-file.jpg');
});<img ngSrc="cat.jpg" width="400" height="200" placeholder="cat-blurred.jpg" />
<button (click)="appRef.destroy()">Destroy</button> |
d192401 to
5240906
Compare
|
@AndrewKushnir added unit test and removal of event listeners in other places too (see comments). |
Prior to this commit, attempting to resolve a `ChangeDetectorRef` after views or app have been destroyed would result in an error. In this commit, we clean up listeners once the view is destroyed, before the placeholder loads or fails to load.
5240906 to
c4b654c
Compare
|
@AndrewKushnir any more changes required for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, calling
ChangeDetectorRef.markForCheck()could schedule a redundant change detection in zoneless mode. This commit ensures listeners are cleaned up once the view is destroyed, preventing unnecessary change detection cycles when placeholders load or fail.