docs(docs-infra): use modern apis #61706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bce5972 to
937b7f0
Compare
|
Deployed adev-preview for 937b7f0 to: https://ng-dev-previews-fw--pr-angular-angular-61706-adev-prev-l16a3nyy.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
hawkgs
reviewed
Jun 3, 2025
| this.setupPageNavigationDimming(); | ||
| } | ||
|
|
||
| /** | ||
| * Dims the main router-outlet content when navigating to a new page. | ||
| */ | ||
| private setupPageNavigationDimming() { | ||
| if (!this.isBrowser) { | ||
| if (this.isServer) { |
There was a problem hiding this comment.
Is this changed in order to avoid the !?
This is purely semantical and there isn't anything to suggest that we will support new platforms, so you can ignore my comment, but the check goes from "run only on a browser" (as intended) to "run on everything but a server".
There was a problem hiding this comment.
Yeah is was basically to drop the !
hawkgs
reviewed
Jun 3, 2025
hawkgs
approved these changes
Jun 3, 2025
|
This PR was merged into the repository by commit e555c7f. The changes were merged into the following branches: main, 20.0.x |
kirjs
pushed a commit
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.