Skip to content

refactor(core): export signal setter and updater types for wiz #61714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): export signal setter and updater types for wiz #61714

wants to merge 1 commit into from
+2 −2

Conversation

tsc036
Copy link
Contributor

@tsc036 tsc036 commented May 27, 2025

Export signal setter and updater types for Wiz to use

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Exports the signal getter, setter, and updater types so they can be used in Wiz.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Types are not exported.

Issue Number: b/396516428

What is the new behavior?

Types are exported.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@tsc036
refactor(core): export signal setter and updater types for wiz
a97cf64 
Export signal setter and updater types for Wiz to use
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 27, 2025
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label May 27, 2025
@ngbot ngbot bot added this to the Backlog milestone May 27, 2025
@tsc036
Copy link
Contributor Author

tsc036 commented May 28, 2025 •
edited
Loading

TESTED=No tgp needed because this pr only exports types

@pkozlowski-opensource
Copy link
Member

LGTM

Reviewed-for: primitives

kirjs
kirjs reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global

@kirjs kirjs added the target: patch This PR is targeted for the next patch release label Jun 2, 2025
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirjs kirjs kirjs left review comments

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@rahatarmanahmed rahatarmanahmed rahatarmanahmed approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@tsc036 @pkozlowski-opensource @kirjs @rahatarmanahmed @JeanMeche