Skip to content

fix(common): HttpResource errors should always be instance of Error #61736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(common): HttpResource errors should always be instance of Error #61736

wants to merge 1 commit into from
+1 −1

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 28, 2025 •
edited
Loading

Adds explicit Error|HttpErrorResponse to the type of error rather than
using any.

@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label May 28, 2025
@ngbot ngbot bot added this to the Backlog milestone May 28, 2025
@atscott atscott added the requires: TGP This PR requires a passing TGP before merging is allowed label May 28, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label May 28, 2025
@atscott atscott added target: patch This PR is targeted for the next patch release requires: TGP This PR requires a passing TGP before merging is allowed labels May 28, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label May 28, 2025
@atscott
Copy link
Contributor Author

atscott commented May 29, 2025

TGP

@atscott atscott force-pushed the httpresourceerrorwrap branch from baea087 to 65cbb64 Compare May 30, 2025 17:47
@atscott
refactor(common): Add explicit type to error handling for resource
c40ed76 
Adds explicit `Error|HttpErrorResponse` to the type of error rather than
using `any`.
@atscott atscott force-pushed the httpresourceerrorwrap branch from 65cbb64 to c40ed76 Compare May 30, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
1 participant
@atscott