Skip to content

chore(elements): create application ref for each custom component #61753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(elements): create application ref for each custom component #61753

wants to merge 2 commits into from
+98 −78

Conversation

MillerSvt
Copy link

@MillerSvt MillerSvt commented May 29, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

Note

If approved, I will complete these tasks.

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

All custom elements live inside single application ref.

Issue #61752

What is the new behavior?

Added possibility to create new application ref for each custom element.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: elements Issues related to Angular Elements label May 29, 2025
@ngbot ngbot bot added this to the Backlog milestone May 29, 2025
@MillerSvt MillerSvt force-pushed the create-custom-elements-with-app-ref branch from 6b2de41 to ab0ef29 Compare May 29, 2025 16:06
@MillerSvt MillerSvt marked this pull request as ready for review May 29, 2025 16:06
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label May 29, 2025
@pullapprove pullapprove bot requested a review from crisbeto May 29, 2025 16:06
@MillerSvt
Copy link
Author

The primary issue at hand is the asynchronous creation of application references. I propose we introduce an option to disable asynchronous APP_INITIALIZERS, addressing this concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: elements Issues related to Angular Elements detected: feature PR contains a feature commit
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
1 participant
@MillerSvt