Skip to content

docs: replace undefined 'heroId' with defined 'id' #61798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: replace undefined 'heroId' with defined 'id' #61798

wants to merge 1 commit into from
+1 −1

Conversation

ituxka
Copy link
Contributor

@ituxka ituxka commented May 31, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from kirjs May 31, 2025 22:38
@JeanMeche JeanMeche added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 1, 2025
@JeanMeche
Copy link
Member

Hi, can you please reword your commit and make it a docs: ... commit to follow our guidelines. Thank you.

@kirjs kirjs added the area: docs Related to the documentation label Jun 3, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 3, 2025
thePunderWoman
thePunderWoman approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@thePunderWoman thePunderWoman removed the request for review from kirjs June 4, 2025 17:41
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 4, 2025
@kirjs
Copy link
Contributor

kirjs commented Jun 4, 2025

This PR was merged into the repository by commit 460b41b.

The changes were merged into the following branches: main, 20.0.x

kirjs pushed a commit that referenced this pull request Jun 4, 2025
@ituxka @kirjs
docs: replace undefined 'heroId' with defined 'id' (#61798)
b75094d 
PR Close #61798
@kirjs kirjs closed this in 460b41b Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@ituxka @JeanMeche @kirjs @thePunderWoman