build: migrate packages/compiler-cli to ts_project
#61826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec947de to
3ab61ce
Compare
This commit migrates the remaining pieces of `compiler-cli` to `ts_project`. This involves a few more things during migration: - the `ng_module` ngc_wrapped rule broke as part of this change, so we switched it to `ts_project` too. This logic is soon gone anyway. - we needed an extra pnpm "package.json" for the linker babel test. This test is loading from the real compiler-cli npm package. Babel needs a real node module for this, so this solution seems reasonable. It may be worth exploring in the future to move this test into an integration test though. - the older integrationtest in compiler-cli is removed as the coverage is much better with the compliance test suite and this test.
The bazel npm package is no longer needed and currently breaks as we started using a 1P pnpm linked package that would otherwise end up being pulled into this legacy rule.
3ab61ce to
da209e3
Compare
crisbeto
approved these changes
Jun 2, 2025
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR was merged into the repository by commit 3af65af. The changes were merged into the following branches: main |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jun 3, 2025
The bazel npm package is no longer needed and currently breaks as we started using a 1P pnpm linked package that would otherwise end up being pulled into this legacy rule. PR Close #61826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the remaining pieces of
compiler-clitots_project. This involves a few more things during migration:the
ng_modulengc_wrapped rule broke as part of this change, so we switched it tots_projecttoo. This logic is soon gone anyway.we needed an extra pnpm "package.json" for the linker babel test. This test is loading from the real compiler-cli npm package. Babel needs a real node module for this, so this solution seems reasonable. It may be worth exploring in the future to move this test into an integration test though.
the older integrationtest in compiler-cli is removed as the coverage is much better with the compliance test suite and this test.