Skip to content

docs(docs-infra): Show deprecation message on the API docs #61828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs(docs-infra): Show deprecation message on the API docs #61828

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Jun 2, 2025 •
edited
Loading

@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Jun 2, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 2, 2025
@JeanMeche JeanMeche force-pushed the docs/ngfor-deprecation-warnings branch from 6a3d3c8 to 1317f98 Compare June 2, 2025 15:33
@JeanMeche JeanMeche requested a review from AndrewKushnir June 2, 2025 15:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

Deployed adev-preview for 069772c to: https://ng-dev-previews-fw--pr-angular-angular-61828-adev-prev-f8qqwi71.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche force-pushed the docs/ngfor-deprecation-warnings branch 4 times, most recently from 66fd761 to 50956da Compare June 2, 2025 20:05
AndrewKushnir
AndrewKushnir reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche thanks for the update! 👍

Quick question: would it be straightforward to swap "directive" and "deprecated" label colors (see this page for an example)? it'd be great to make the "deprecated" label red.

@JeanMeche JeanMeche force-pushed the docs/ngfor-deprecation-warnings branch 2 times, most recently from 97eb848 to 68f3ca8 Compare June 3, 2025 12:58
@JeanMeche JeanMeche marked this pull request as ready for review June 3, 2025 13:02
@JeanMeche
Copy link
Member Author

The change also addresses the color issue for the deprecate label 👍

@JeanMeche JeanMeche force-pushed the docs/ngfor-deprecation-warnings branch 3 times, most recently from 6642123 to 208314e Compare June 3, 2025 13:50
@JeanMeche JeanMeche force-pushed the docs/ngfor-deprecation-warnings branch from 208314e to 069772c Compare June 3, 2025 14:45
AndrewKushnir
AndrewKushnir approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @JeanMeche 👍

@AndrewKushnir AndrewKushnir added the target: patch This PR is targeted for the next patch release label Jun 3, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jun 4, 2025
@JeanMeche
Copy link
Member Author

caretaker note: To merge this PR we'll need to update one of the g3 patches.

@JeanMeche JeanMeche closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@JeanMeche @AndrewKushnir