-
Notifications
You must be signed in to change notification settings - Fork 26.3k
build: migrate partial compliance tests to rules_js #61865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+2,804
−2,708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e3dac1
to
1c30f54
Compare
josephperrott
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl
Show resolved
Hide resolved
082b341
to
e3a6284
Compare
For the `rules_js` migration, we are facing the problem where our current Angular code is shipped as ESM, but we aren't fully there yet with fully compliant strict ESM during development. That is because we lack explicit import extensions, and it's also a different story how this would work in Google3, if we were to add them. In addition, we cross-import from our packages using npm module names. This works well for TS, for ESBuild because those can respect path mappings— but at runtime, when executing native `jasmine_test`'s— such mappings aren't respected. The options here are: - avoid module imports in the repo (impossible; undesired) - use pre-bundling of all NodeJS execution involving npm package code (slower, extra build action cost) - wire up a simple NodeJS loader (supported via official APIs) to simply account for our cases (preferred and similar to what we experimented with for the last year(s); and worked well) This commit implements the last option and allows for an easy migration to `rules_js`, and also is pretty reasonable. Long-term we can resolve the extension problem if we e.g. migrate to real explicit extensions + a proper TS module resolution like e.g. `nodenext`.
Migrates the partial compliance tests to `rules_js`. Also as part of this, we re-enable RBE to see if that fixed the issues, or in case they are already resolved from the RBE side.
This PR was merged into the repository by commit 93c74ef. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
area: build & ci
Related the build and CI infrastructure of the project
target: minor
This PR is targeted for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits