refactor(core): use version>0 instead of hasRun #62467
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneajaho
reviewed
Jul 4, 2025
| return; | ||
| } | ||
| this.hasRun = true; | ||
| this.version++; |
There was a problem hiding this comment.
I guess setting a value to true will be cheaper memory wise, as there would be no need to allocate memory for each new value that ++ generates, while the boolean flag only allocates memory once, and uses that memory location.
There was a problem hiding this comment.
It's just a number though (fixed 64 bit), It shouldn't really matter ?
There was a problem hiding this comment.
This has to go through the perf benchmarks I guess.
There was a problem hiding this comment.
In fact, in V8 this is going to be stored as an SMI (so a 32 bit integer). So unless there will be 2 billion increments, the impact is pretty minimal.
this saves a field for effect and watch nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
This saves a field for effect and watch nodes. Additionally, it should make effect nodes flash in the devtools when they rerun.
Does this PR introduce a breaking change?
Other information