Skip to content

build: update bazel dependencies (main) #62542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: update bazel dependencies (main) #62542

wants to merge 1 commit into from

Conversation

angular-robot
Copy link
Collaborator

@angular-robot angular-robot commented Jul 9, 2025 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
aspect_rules_js http_archive minor v2.3.8 -> v2.4.0
rules_browsers git_repository digest 0d82118 -> 56ef800

Release Notes

aspect-build/rules_js (aspect_rules_js)

v2.4.0

Compare Source

Many companies are successfully building with rules_js.
If you're getting value from the project, please let us know!
Just comment on our Adoption Discussion.

Using Bzlmod with Bazel 6:

Add to your MODULE.bazel file:

bazel_dep(name = "aspect_rules_js", version = "2.4.0")

####### Node.js version #########

### By default you get the node version from DEFAULT_NODE_VERSION in @​rules_nodejs//nodejs:repositories.bzl
### Optionally you can pin a different node version:
bazel_dep(name = "rules_nodejs", version = "6.3.0")
node = use_extension("@​rules_nodejs//nodejs:extensions.bzl", "node", dev_dependency = True)
node.toolchain(node_version = "16.14.2")

#################################

npm = use_extension("@​aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True)

npm.npm_translate_lock(
    name = "npm",
    pnpm_lock = "//:pnpm-lock.yaml",
    verify_node_modules_ignored = "//:.bazelignore",
)

use_repo(npm, "npm")

pnpm = use_extension("@​aspect_rules_js//npm:extensions.bzl", "pnpm")

### Allows developers to use the matching pnpm version, for example:
### bazel run -- @​pnpm --dir /home/runner/work/rules_js/rules_js install
use_repo(pnpm, "pnpm")

Using WORKSPACE

Paste this snippet into your WORKSPACE file:

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_rules_js",
    sha256 = "961393890a58de989ad7aa36ce147fc9b15a77c8144454889bf068bdd12c5165",
    strip_prefix = "rules_js-2.4.0",
    url = "https://github.com/aspect-build/rules_js/releases/download/v2.4.0/rules_js-v2.4.0.tar.gz",
)

load("@​aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@​aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@​aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

npm_translate_lock(
    name = "npm",
    npmrc = "//:.npmrc",
    pnpm_lock = "//:pnpm-lock.yaml",
    verify_node_modules_ignored = "//:.bazelignore",
)

load("@​npm//:repositories.bzl", "npm_repositories")

npm_repositories()

What's Changed

New Contributors

Full Changelog: https://github.com/aspect-build/rules\_js/compare/v2.3.8...v2.4.0

Configuration

📅 Schedule: Branch creation - "after 10:00pm every weekday,before 5:00am every weekday,every weekend" in timezone America/Tijuana, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release labels Jul 9, 2025
@angular-robot
Copy link
Collaborator Author

angular-robot commented Jul 9, 2025 •
edited
Loading

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: undefined
Command failed: yarn bazel run //.github/actions/deploy-docs-site:main.update
Loading: 
Loading: 
Loading: 1 packages loaded
ERROR: Skipping '//.github/actions/deploy-docs-site:main.update': no such target '//.github/actions/deploy-docs-site:main.update': target 'main.update' not declared in package '.github/actions/deploy-docs-site' defined by /tmp/renovate/repos/github/angular/angular/.github/actions/deploy-docs-site/BUILD.bazel (Tip: use `query "//.github/actions/deploy-docs-site:*"` to see all the targets in that package)
WARNING: Target pattern parsing failed.
ERROR: no such target '//.github/actions/deploy-docs-site:main.update': target 'main.update' not declared in package '.github/actions/deploy-docs-site' defined by /tmp/renovate/repos/github/angular/angular/.github/actions/deploy-docs-site/BUILD.bazel (Tip: use `query "//.github/actions/deploy-docs-site:*"` to see all the targets in that package)
INFO: Elapsed time: 0.690s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (2 packages loaded)
ERROR: Build failed. Not running target
error Command failed with exit code 1.

@ngbot ngbot bot modified the milestone: Backlog Jul 9, 2025
@pullapprove pullapprove bot requested a review from alxhub July 9, 2025 10:08
@AndrewKushnir
Copy link
Contributor

@josephperrott it looks like CI is failing for this rules_angular update. Is this PR relevant or those updates will be happening as a part of other PRs?

@AndrewKushnir AndrewKushnir requested review from josephperrott and removed request for alxhub July 9, 2025 19:47
@pullapprove pullapprove bot requested a review from alxhub July 9, 2025 19:47
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 9, 2025
@thePunderWoman thePunderWoman removed the action: merge The PR is ready for merge by the caretaker label Jul 11, 2025
@angular-robot angular-robot force-pushed the ng-renovate/main-bazel-dependencies branch from c9e3495 to b7ab8ac Compare July 11, 2025 18:09
@angular-robot angular-robot changed the title build: update rules_angular digest to 8bf9ae3 (main) build: update bazel dependencies (main) Jul 12, 2025
@angular-robot angular-robot force-pushed the ng-renovate/main-bazel-dependencies branch from b7ab8ac to 8de6165 Compare July 12, 2025 22:07
@josephperrott
Copy link
Member

This will become unblocked after #62541 lands

@angular-robot angular-robot changed the title build: update bazel dependencies (main) build: update rules_browsers digest to 56ef800 (main) Jul 14, 2025
@angular-robot
build: update bazel dependencies
9e9fd40 
See associated pull request for more information.
@angular-robot angular-robot force-pushed the ng-renovate/main-bazel-dependencies branch from 8de6165 to 9e9fd40 Compare July 15, 2025 00:52
@angular-robot angular-robot changed the title build: update rules_browsers digest to 56ef800 (main) build: update bazel dependencies (main) Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephperrott josephperrott Awaiting requested review from josephperrott

@alxhub alxhub Awaiting requested review from alxhub

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@angular-robot @AndrewKushnir @josephperrott @thePunderWoman