refacto(compiler): Error on comment only interpolations #62590
Conversation
b7f0558 to
4c98083
Compare
This commit introduces a ParserError to prevent an error later in the pipepine fixes angular#34084
4c98083 to
c2192d6
Compare
| const tokens = this._lexer.tokenize(sourceToLex); | ||
|
|
There was a problem hiding this comment.
I haven't checked what the AST looks like, but couldn't we check that strings.length === 0 and expressions.length === 0?
There was a problem hiding this comment.
On the unit test I provided, both aren't empty: string actually contains 2empty string and expression contains ' // foobar '.
There was a problem hiding this comment.
Hmm that's weird, but it's probably because we should handle comments at the lexer level rather than in the parser.
| const tokens = this._lexer.tokenize(sourceToLex); | ||
|
|
There was a problem hiding this comment.
Hmm that's weird, but it's probably because we should handle comments at the lexer level rather than in the parser.
| const i = this._commentStart(input); | ||
| return i != null ? input.substring(0, i) : input; | ||
| return i != null | ||
| ? {hasComments: true, stripped: input.substring(0, i)} |
There was a problem hiding this comment.
nit: maybe move hasComments to be second so the shape matches with the other variant.
This commit introduces a ParserError to prevent an error later in the pipepine
fixes #34084