fix(core): fix change tracking for Resource#hasValue #62595
Closed
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `hasValue()` I would expect it to behave like any other reactive value such that changes to the internal `value()` that do not cause `hasValue()` to return anything different do not trigger change detection, but this was not the case. This change wraps the value checking in a `computed` such that it behaves as expected again while still preserving the type narrowing.
mmalerba
approved these changes
Jul 16, 2025
|
This PR was merged into the repository by commit b8e415a. The changes were merged into the following branches: main, 20.1.x |
kirjs
pushed a commit
that referenced
this pull request
Jul 18, 2025
When using `hasValue()` I would expect it to behave like any other reactive value such that changes to the internal `value()` that do not cause `hasValue()` to return anything different do not trigger change detection, but this was not the case. This change wraps the value checking in a `computed` such that it behaves as expected again while still preserving the type narrowing. PR Close #62595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
hasValue()I would expect it to behave like any other reactive value such that changes to the internalvalue()that do not causehasValue()to return anything different do not trigger change detection, but this was not the case. This change wraps the value checking in acomputedsuch that it behaves as expected again while still preserving the type narrowing.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Each time a resource's value changes, even if it changes from e.g. a defined to a defined value, consumers of
hasValue()will re-run.Issue Number: N/A
What is the new behavior?
Consumers of
hasValue()will re-run only if it has actually changed, preventing unnecessary change detection.Does this PR introduce a breaking change?
Other information