Skip to content

Refactor macro/rule imports in devtools and adev #62627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Refactor macro/rule imports in devtools and adev #62627

wants to merge 2 commits into from
+236 −372

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott requested a review from devversion July 14, 2025 14:47
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Jul 14, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 14, 2025
@josephperrott josephperrott added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 14, 2025
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 14, 2025
@AndrewKushnir
Copy link
Contributor

@josephperrott adding the "cleanup" label to this PR for now, since it contains some merge conflicts. Please rebase and resolve conflicts when you get a chance.

@josephperrott
build: move all rule/macro loading into devtools/defaults.bzl
97cf331 
Move all of our loading into a local defaults.bzl file instead of mixed loading via tools/defaults and devtolls/defaults
@josephperrott
build: move all rule/macro loading into adev/defaults.bzl and fix int…
905a87e 
…ellisense loading

Move all of our loading into a local defaults.bzl file instead of mixed loading via tools/defaults and adev/defaults
@josephperrott josephperrott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 14, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit e8c5603.

The changes were merged into the following branches: main

AndrewKushnir pushed a commit that referenced this pull request Jul 14, 2025
@josephperrott @AndrewKushnir
build: move all rule/macro loading into adev/defaults.bzl and fix int…
e8c5603 
…ellisense loading (#62627)

Move all of our loading into a local defaults.bzl file instead of mixed loading via tools/defaults and adev/defaults

PR Close #62627
@JeanMeche JeanMeche mentioned this pull request Jul 18, 2025
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@josephperrott @AndrewKushnir @devversion