Skip to content

refactor(signal-forms): remove error logic function #62634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

mmalerba
Copy link
Contributor

We have gotten feedback from multiple sources that the distinction between error and validate is confusing. Removing error for now and we will explore alternate method signatures for validate instead in future PRs

@mmalerba mmalerba requested review from leonsenft, kirjs and alxhub July 14, 2025 22:34
@mmalerba mmalerba added area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Jul 14, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 14, 2025
@mmalerba mmalerba self-assigned this Jul 14, 2025
We have gotten feedback from multiple sources that the distinction
between `error` and `validate` is confusing. Removing `error` for now
and we will explore alternate method signatures for `validate` instead
in future PRs
@mmalerba mmalerba merged commit 2648e75 into angular:prototype/signal-forms Jul 15, 2025
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants