feat(signal-forms): allow validation logic to return null and false #62657
+106
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonsenft
reviewed
Jul 16, 2025
fbbc21f to
4b0262b
Compare
leonsenft
approved these changes
Jul 16, 2025
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request modifies the forms validation logic to allow null and false to be returned from validation functions, indicating no errors. This change simplifies validation code and improves developer experience. The implementation includes updates to type definitions, refactoring of ArrayMergeLogic, and the addition of a new test case. I've provided feedback addressing a potential runtime error and suggesting code cleanup for improved clarity.
ebb6786
into
angular:prototype/signal-forms
11 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that's come up a few times during development of this prototype is that it would be nice to allow returning values like
nullandfalsefrom validation logic functions. This helps people write more concise logic without the need for extraifblocks or ternaries. e.g.:We've also seen LLMs trip up and
return nullat the end of the validation function if there are no errors, rather thanreturn undefined. It makes sense that either of these should work to indicate no error.