refactor(core): Only log the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MO… #62658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DE warning once This reduces the number of times the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MODE warning is logged. This warning is especially spammy in tests.
|
Fwiw, this error being spammy is what lead me to investigate and land #62596. |
|
@JeanMeche that’s a fair point. I think one motivation for making it less spammy is that I would actually encourage and expect more Zoneless tests during migration (or even not). With Zoneless becoming the default, it may be that only a few tests truly need to test something specific to the ZoneJs integration but the rest can/should potentially operate in Zoneless mode by default but not necessarily require two splitting those out into a different test target. I also don’t think the original intent was to log on every test execution but for it to log once on app load. I could see this both ways though… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DE warning once
This reduces the number of times the UNEXPECTED_ZONEJS_PRESENT_IN_ZONELESS_MODE warning is logged. This warning is especially spammy in tests.