Review of api/validators #62659
Open
Review of api/validators #62659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
commented
Jul 16, 2025
f80ee5a to
22b7174
Compare
Improves the ergonomics of the `errors` option offered by the standard validators. 1. Renames it to `error` because in the majority of cases it will be used to return a single `ValidationError`. 2. Allows directly using a constant `ValidationError` insetad of having to create a function like `() => ValidationError.custom()`
f04b1ed to
ed163e7
Compare
5599dfb to
9f2fb96
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request focuses on refactoring the forms validators API to enhance consistency and reactivity. Key changes include renaming minlength/maxlength to camelCase, standardizing validator configuration with an error property, and updating most validators to use a more reactive implementation with define and computed. The JSDoc and test suites have also been updated accordingly.
9f2fb96 to
63929b2
Compare
leonsenft
requested changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits which address the TODOs I initially commented