feat(forms): switch to RegExp in pattern validator #62671
+22
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No other libraries use string patterns for validation
mmalerba
reviewed
Jul 16, 2025
|
|
||
| metadata(path, PATTERN, (ctx) => { | ||
| const result = reactivePatternValue(ctx); | ||
| if (result === undefined) { | ||
| return []; | ||
| } | ||
| return [result]; | ||
| return [result.source]; |
There was a problem hiding this comment.
shouldn't we switch the PATTERN metadata to be an array of RegExp?
There was a problem hiding this comment.
How is the PATTERN metadata intended to be used?
There was a problem hiding this comment.
It is just to give the user some way to get the list of patterns that are being applied to the field. They could use it to set the pattern attribute if they want, or to show a "hint" message under the input like "your username must be formatted like: ...".
Most users probably don't care too much about it, but for things like required and min, the metadata is very important because it can be used to show the required * or set the min attribute on the input. For consistency we give you the pattern as metadata too
leonsenft
reviewed
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.