Skip to content

refactor(core): Use promise.finally for task removal #62674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): Use promise.finally for task removal #62674

wants to merge 1 commit into from
+4 −6

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jul 16, 2025

Updates the approach from #62631 to use Promise.finally for task removal. This is a bit cleaner and also handles rejections from the donePromise

@atscott
refactor(core): Use promise.finally for task removal
191cb56 
Updates the approach from angular#62631 to
use Promise.finally for task removal. This is a bit cleaner and also handles
rejections from the donePromise
@atscott atscott requested a review from thePunderWoman July 16, 2025 20:21
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jul 16, 2025
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jul 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 16, 2025
thePunderWoman
thePunderWoman approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jul 16, 2025
@kirjs
Copy link
Contributor

kirjs commented Jul 18, 2025

This PR was merged into the repository by commit 448a7f7.

The changes were merged into the following branches: main, 20.1.x

kirjs pushed a commit that referenced this pull request Jul 18, 2025
@atscott @NothingEverHappens
refactor(core): Use promise.finally for task removal (#62674)
ba8a5d8 
Updates the approach from #62631 to
use Promise.finally for task removal. This is a bit cleaner and also handles
rejections from the donePromise

PR Close #62674
@kirjs kirjs closed this in 448a7f7 Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@atscott @kirjs @thePunderWoman