refactor(devtools): restyle the signal details panel #62681
Closed
+366
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
Jul 17, 2025
...devtools-tabs/directive-explorer/signals-view/signals-details/signals-details.component.html
Outdated
Show resolved
Hide resolved
b368d83 to
9d8e40b
Compare
JeanMeche
approved these changes
Jul 17, 2025
hawkgs
commented
Jul 17, 2025
Comment on lines
+22
to
+23
| @if (node.preview.preview === 'undefined') { | ||
| <div class="value">undefined</div> |
There was a problem hiding this comment.
@milomg, does this make sense? Using just "undefined" instead of "Computed signal value is undefined"?
e3b8703 to
7e7e928
Compare
milomg
approved these changes
Jul 17, 2025
dgp1130
approved these changes
Jul 17, 2025
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
Restyle the details panel to match and be inline with the existing UI/style.
7e7e928 to
fee8b07
Compare
|
No functional changes. |
|
This PR was merged into the repository by commit d3b770d. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Restyle the details panel to match and be inline with the existing UI/style.
Changes:
signal-details) for easier stylization.signals-value-treeis moved in a separated folder with separate a BUILD file.signal-detailsandsignals-value-treeare restyled.The design resembles the initial wireframes.