Skip to content

docs(signal-forms): add some tsdoc for async validation api #62693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: prototype/signal-forms
Choose a base branch
from
Open

docs(signal-forms): add some tsdoc for async validation api #62693

wants to merge 3 commits into from
+141 −61

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested review from leonsenft and kirjs July 17, 2025 20:58
@mmalerba mmalerba requested a review from alxhub July 17, 2025 20:58
@ngbot ngbot bot added this to the Backlog milestone Jul 17, 2025
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jul 17, 2025
@mmalerba
Copy link
Contributor Author

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 17, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds TSDoc comments to the async validation API in signal-based forms, improving documentation and developer experience. The changes also refactor some types for better clarity and type safety.

leonsenft
leonsenft requested changes Jul 17, 2025
View reviewed changes
@mmalerba mmalerba requested a review from leonsenft July 18, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@kirjs kirjs Awaiting requested review from kirjs

@alxhub alxhub Awaiting requested review from alxhub

@leonsenft leonsenft Awaiting requested review from leonsenft

Assignees
No one assigned
Labels
area: docs Related to the documentation area: forms
Projects
Experimental Signal Forms
Status: No status
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalerba @leonsenft