Skip to content

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jul 17, 2025

This option was introduced out of caution as a way for developers to opt out of the new behavior in v18 which scheduled change detection even when events happened outside the NgZone. After monitoring the results post-release, we have determined that this feature is working as desired and do not believe it should ever be disabled by setting this option to true.

This option was deprecated in v18.2, less than 3 months after it was introduced in v18. We do not really expect it to be used.

BREAKING CHANGE: ignoreChangesOutsideZone is no longer available as an option for configuring ZoneJS change detection behavior.

@atscott atscott added the target: major This PR is targeted for the next major release label Jul 17, 2025
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: core Issues related to the framework runtime labels Jul 17, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 17, 2025
@atscott atscott force-pushed the removeIgnoreChangesOutsideZone branch from 06a5cd6 to 6deaf23 Compare July 23, 2025 21:22
This option was introduced out of caution as a way for developers to opt out of
the new behavior in v18 which scheduled change detection even when
events happened outside the NgZone. After monitoring the results post-release, we
have determined that this feature is working as desired and do not believe it
should ever be disabled by setting this option to `true`.

This option was deprecated in v18.2, less than 3 months after it was
introduced in v18. We do not really expect it to be used.

BREAKING CHANGE: `ignoreChangesOutsideZone` is no longer available as an
option for configuring ZoneJS change detection behavior.
@atscott atscott marked this pull request as ready for review August 29, 2025 19:13
@atscott atscott force-pushed the removeIgnoreChangesOutsideZone branch from 6deaf23 to 65dbd07 Compare August 29, 2025 19:13
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from kirjs August 29, 2025 20:44
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Aug 29, 2025
@ngbot
Copy link

ngbot bot commented Aug 29, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@JeanMeche JeanMeche removed the request for review from thePunderWoman September 2, 2025 12:53
@mmalerba
Copy link
Contributor

mmalerba commented Sep 2, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@mmalerba mmalerba closed this in 92e09ad Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants