Skip to content

fix(migrations): incorrect filtering in inject migration #62913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(migrations): incorrect filtering in inject migration #62913

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

The inject migration wasn't implementing file filtering properly which resulted in it passing an invalid tsconfig path to TypeScript.

Fixes #62866.

@crisbeto
fix(migrations): incorrect filtering in inject migration
12c7edd 
The inject migration wasn't implementing file filtering properly which resulted in it passing an invalid tsconfig path to TypeScript.

Fixes angular#62866.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 31, 2025
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Jul 31, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 31, 2025
@crisbeto crisbeto mentioned this pull request Jul 31, 2025
Closed
@crisbeto crisbeto requested a review from JoostK July 31, 2025 07:52
JoostK
JoostK approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this makes a lot more sense!

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 31, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit b1514d5.

The changes were merged into the following branches: main, 20.1.x

thePunderWoman pushed a commit that referenced this pull request Jul 31, 2025
@crisbeto @thePunderWoman
fix(migrations): incorrect filtering in inject migration (#62913)
7a5851e 
The inject migration wasn't implementing file filtering properly which resulted in it passing an invalid tsconfig path to TypeScript.

Fixes #62866.

PR Close #62913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoostK JoostK JoostK approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

inject migration fails to migrate file at given path
3 participants
@crisbeto @thePunderWoman @JoostK