Skip to content

feat(platform-browser): Warns on conflicting hydration and blocking n… #62963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Aug 2, 2025

Adds an internal injection token to detect and warn when both hydration and blocking initial navigation are enabled simultaneously.

Since this combination is currently unsupported and may lead to unexpected runtime issues, a warning is now logged during application initialization to alert developers early in the lifecycle.

This helps prevent subtle misconfigurations and aligns with the resolution of #59624

Changes included:

  • Introduced an internal token to detect the configuration conflict.

  • Logged a console.warn during app bootstrap when both features are enabled.

@pullapprove pullapprove bot requested a review from mmalerba August 2, 2025 02:31
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Aug 2, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 2, 2025
…avigation

Adds an internal token to detect when both hydration and blocking initial navigation are enabled. Logs a warning during app initialization if this unsupported combination is found, helping developers avoid misconfiguration and potential runtime issues.
@SkyZeroZx SkyZeroZx force-pushed the add-warning-initial-blocking branch from 64e0477 to 52e037e Compare August 3, 2025 03:06
@JeanMeche JeanMeche requested review from thePunderWoman and removed request for mmalerba August 5, 2025 02:24
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@thePunderWoman thePunderWoman added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Aug 5, 2025
@crisbeto
Copy link
Member

crisbeto commented Aug 5, 2025

This PR was merged into the repository by commit 52b8e07.

The changes were merged into the following branches: main

@crisbeto crisbeto closed this in 52b8e07 Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants