Skip to content

fix(core): properly recognize failed fetch responses when loading external resources in JIT #62992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): properly recognize failed fetch responses when loading external resources in JIT #62992

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

Currently when loading external resources in JIT, when fetch fails, the text is empty and the component is loading. This hides the actual underlying fetch error. We should properly detect this and error out.

@devversion devversion requested a review from crisbeto August 4, 2025 19:18
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Aug 4, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 4, 2025
@devversion
fix(core): properly recognize failed fetch responses when loading e…
8bfd8a6 
…xternal resources in JIT

Currently when loading external resources in JIT, when `fetch` fails,
the `text` is empty and the component is loading. This hides the actual
underlying fetch error. We should properly detect this and error out.
@devversion devversion force-pushed the external-resources-fetch branch from 4619375 to 8bfd8a6 Compare August 4, 2025 19:36
jelbourn
jelbourn approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-approvers

@devversion devversion added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 4, 2025
@devversion
Copy link
Member Author

devversion commented Aug 5, 2025 •
edited
Loading

Caretaker note: This has a passing TGP

@devversion devversion added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 5, 2025
@crisbeto
Copy link
Member

crisbeto commented Aug 5, 2025

This PR was merged into the repository by commit 648bbb0.

The changes were merged into the following branches: main, 20.1.x

crisbeto pushed a commit that referenced this pull request Aug 5, 2025
@devversion @crisbeto
fix(core): properly recognize failed fetch responses when loading e…
c9f3976 
…xternal resources in JIT (#62992)

Currently when loading external resources in JIT, when `fetch` fails,
the `text` is empty and the component is loading. This hides the actual
underlying fetch error. We should properly detect this and error out.

PR Close #62992
@crisbeto crisbeto closed this in 648bbb0 Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime hotlist: google merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @crisbeto @jelbourn