fix(core): fixes empty animations when recalculating styles #63007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e6ca5c to
e53d841
Compare
Any time something causes styles to recalculate, `element.getAnimations()` will be empty. This updates `animate.enter` and `animate.leave` to rely on `getComputedStyles` to determine the longest animation instead. fixes: angular#63006
e53d841 to
cc6e168
Compare
crisbeto
approved these changes
Aug 6, 2025
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
This PR was merged into the repository by commit ebd622b. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time something causes styles to recalculate,
element.getAnimations()will be empty. This updatesanimate.enterandanimate.leaveto rely ongetComputedStylesas a fallback to determine the longest animation.This should also improve performance as this reduces the calls to get the longest animation only when the event.target is the element in question. It'll ignore bubbled up animation events now.
fixes: #63006