-
Notifications
You must be signed in to change notification settings - Fork 26.5k
feat(router): add a currentNavigation signal to the Router service. #63011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feb070a
to
9307c27
Compare
atscott
approved these changes
Aug 5, 2025
32f84e5
to
78f36a9
Compare
atscott
approved these changes
Aug 5, 2025
thePunderWoman
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api, size-tracking
We should run a TGP for this since it broke some targets last time around. |
ranma42
reviewed
Aug 6, 2025
packages/core/schematics/migrations/router-current-navigation/README.md
Outdated
Show resolved
Hide resolved
This new signal property is convenient to derive a `isNavigating` state. `isNavigating = computed(() => !!this.router.currentNavigation())` DEPRECATED: The Router.getCurrentNavigation method is deprecated. Use the Router.currentNavigation signal instead. fixes angular#62958
78f36a9
to
e650fb4
Compare
atscott
approved these changes
Aug 6, 2025
This PR was merged into the repository by commit 687c374. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
area: router
detected: deprecation
PR contains a commit with a deprecation
detected: feature
PR contains a feature commit
target: minor
This PR is targeted for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This #62971 re-opened
This new signal property is convenient to derive a
isNavigating
state.isNavigating = computed(() => !!this.router.currentNavigation())
DEPRECATED: The Router.getCurrentNavigation method is deprecated. Use the Router.currentNavigation signal instead.
fixes #62958