Skip to content

fix(compiler): fixes animation event host bindings not firing #63217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler): fixes animation event host bindings not firing #63217

wants to merge 1 commit into from

Conversation

thePunderWoman
Copy link
Contributor

Host bindings for (animate.enter) and (animate.leave) were not firing properly. This fixes the compiler ingest to make sure they do fire.

fixes: #63199

  • Yes
  • No

@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate labels Aug 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 18, 2025
crisbeto
crisbeto reviewed Aug 18, 2025
View reviewed changes
@thePunderWoman
fix(compiler): fixes animation event host bindings not firing
c018748 
Host bindings for `(animate.enter)` and `(animate.leave)` were not firing properly. This fixes the compiler ingest to make sure they do fire.

fixes: angular#63199
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Aug 18, 2025
@ngbot
Copy link

ngbot bot commented Aug 18, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman
Copy link
Contributor Author

This PR was merged into the repository by commit cab3adf.

The changes were merged into the following branches: main, 20.2.x

thePunderWoman added a commit that referenced this pull request Aug 18, 2025
@thePunderWoman
fix(compiler): fixes animation event host bindings not firing (#63217)
7b51728 
Host bindings for `(animate.enter)` and `(animate.leave)` were not firing properly. This fixes the compiler ingest to make sure they do fire.

fixes: #63199

PR Close #63217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Provide hostbinding for (animate.enter) and (animate.leave) events
2 participants
@thePunderWoman @crisbeto