build(devtools): add hermetic release build environment #63302
+101
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh dammit, apparently you can't install it on Mac (I swear I saw a |
josephperrott
approved these changes
Aug 21, 2025
1f0d759 to
e75c517
Compare
Build verification for Mozilla Add Ons has been incredibly inconsistent with difficulties getting the information necessary to debug. This uses `podman` as a hermetic build environment to create something a little more reliable and consistent between Angular developers and Mozilla reviewers. I opted for `podman` over Docker because the latter requires some extra approvals we don't want to deal with (see http://go/vm-exception). It ultimately works with the containerfile format, so the DX is fairly comparable to Docker. The hardest part was getting Node installed, as `nvm install` just wouldn't work for reasons I couldn't figure out. Instead, I manually downloaded it using the same version from `.nvmrc`. I didn't update the release docs as I suspect it would be somewhat reudundant to ask Angular caretakers to go through this process and it significantly hurts build times since remote builds aren't configured. If we find discrepancies between local builds and the `podman` builds, then we might want to re-evaluate that decision. I validated by performing a release build with and without `podman` and confirming that the extracted ZIP files are identical for both Chrome and Firefox. I also included this build as a CI task, since we want to make sure this remains stable for Mozilla reviewers.
e75c517 to
47327c4
Compare
|
Ok, I switched over to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build verification for Mozilla Add Ons has been incredibly inconsistent with difficulties getting the information necessary to debug. This uses
podmanas a hermetic build environment to create something a little more reliable and consistent between Angular developers and Mozilla reviewers.I opted for
podmanover Docker because the latter requires some extra approvals we don't want to deal with (see http://go/vm-exception). It ultimately works with the containerfile format, so the DX is fairly comparable to Docker. The hardest part was getting Node installed, asnvm installjust wouldn't work for reasons I couldn't figure out. Instead, I manually downloaded it using the same version from.nvmrc.I didn't update the release docs as I suspect it would be somewhat reudundant to ask Angular caretakers to go through this process and it significantly hurts build times since remote builds aren't configured. If we find discrepancies between local builds and the
podmanbuilds, then we might want to re-evaluate that decision. I validated by performing a release build with and withoutpodmanand confirming that the extracted ZIP files are identical for both Chrome and Firefox.I also included this build as a CI task, since we want to make sure this remains stable for Mozilla reviewers.
@jkrems, before we merge this, can you pull the PR and make sure it works for you on Mac? I tried to keep it as simple as possible, but I think there's a reasonable risk of the Bash being non-portable to Mac, so I want to make sure that gets sorted.