Skip to content

fix(core): Fixes animate.leave binding to a string with spaces #63366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): Fixes animate.leave binding to a string with spaces #63366

wants to merge 1 commit into from

Conversation

thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Aug 25, 2025 •
edited
Loading

This fixes the rare case that someone uses binding syntax with animate.leave providing a value with a string that has spaces in it. For example:

<example [animate.leave]="'class-a class-b" />

fixes: #63365

@thePunderWoman
fix(core): Fixes animate.leave binding to a string with spaces
d7b8e77 
This fixes the rare case that someone uses binding syntax with `animate.leave` providing a value with a string that has spaces in it. For example:

```
<example `[animate.leave]="'class-a class-b"` />
```

fixes: angular#63365
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Aug 25, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 25, 2025
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 25, 2025
AndrewKushnir pushed a commit that referenced this pull request Aug 25, 2025
@thePunderWoman @AndrewKushnir
fix(core): Fixes animate.leave binding to a string with spaces (#63366
c8f07da 
)

This fixes the rare case that someone uses binding syntax with `animate.leave` providing a value with a string that has spaces in it. For example:

```
<example `[animate.leave]="'class-a class-b"` />
```

fixes: #63365

PR Close #63366
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

BUG - new animations API problem with binding multiple values as string
3 participants
@thePunderWoman @AndrewKushnir @JeanMeche