Skip to content

docs(docs-infra): marks properties protected used in template #63513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs(docs-infra): marks properties protected used in template #63513

wants to merge 1 commit into from

Conversation

MeAkib
Copy link
Contributor

@MeAkib MeAkib commented Aug 31, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mmalerba August 31, 2025 17:16
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Aug 31, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 31, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 31, 2025
@JeanMeche JeanMeche removed the request for review from mmalerba August 31, 2025 17:18
@JeanMeche JeanMeche added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Aug 31, 2025
@JeanMeche
Copy link
Member

Looks like one of the changes is breaking the tests, can you please have a look, thank you.

@MeAkib MeAkib force-pushed the refactor/protected-used-in-template branch from 9c45046 to 40d55bb Compare August 31, 2025 18:32
@angular-robot angular-robot bot requested a review from JeanMeche August 31, 2025 18:32
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 1, 2025
@mmalerba
Copy link
Contributor

mmalerba commented Sep 2, 2025

This PR was merged into the repository. The changes were merged into the following branches:

mmalerba pushed a commit that referenced this pull request Sep 2, 2025
@MeAkib @mmalerba
docs(docs-infra): marks properties protected used in template (#63513)
f204b54 
PR Close #63513
@mmalerba mmalerba closed this in db8b44c Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@MeAkib @JeanMeche @mmalerba