refactor(devtools): intergrate the TreeVisualizer into the TreeVisualizerHost component #63530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
954c1e7 to
2144618
Compare
dgp1130
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
No immediate concerns on my side, but I admit a lot of the router tree stuff goes over my head, so I'm not entirely following the change here. Maybe @AleksanderBodurri or @sumitarora could provide more meaningful feedback than I can?
|
@dgp1130, I hope that this timeline clarifies the purpose of this change:
|
…izerHost component Use the `TreeVisualizer` internally in the host component instead of managing these separately in their client components.
2144618 to
498fdbd
Compare
652ddc1 to
d1786f6
Compare
hawkgs
commented
Sep 3, 2025
Comment on lines
-1
to
-4
| @if (routerDebugApiSupport()) { | ||
| <div class="filter"> | ||
| <input | ||
| #searchInput |
There was a problem hiding this comment.
@AleksanderBodurri, would it make sense to you to disable the tab from here instead:
I assume this check was added to cover the case when the router tree tab has been enabled in a previous session, but we don't have routes to show in the current one, since the switch in the settings menu is already rendered only if supportedApis.routes is true.
…eVisualizerHost component
d1786f6 to
3608ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
TreeVisualizeris instantiated directly in the client components.What is the new behavior?
Use the
TreeVisualizerinternally in theTreeVisualizerHostcomponent instead of managing these separately in their client components (e.g. Injector and Router tree components/tabs).