feat(platform-server): update server bootstrap API #63562
+571
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93d4db6 to
a2d0427
Compare
b705644 to
6947b29
Compare
|
caretaker note: this requires a separate patch in G3 http://cl/802466606 |
6947b29 to
837b218
Compare
jkrems
approved these changes
Sep 3, 2025
| * Having a separate symbol for the module boostrap implementation allows us to | ||
| * tree shake the module based boostrap implementation in standalone apps. | ||
| * Having a separate symbol for the module bootstrap implementation allows us to | ||
| * tree shake the module based bootstrap implementation in standalone apps. |
There was a problem hiding this comment.
So much less scary without all the "boos"!
(Thanks for cleaning these up!)
packages/core/schematics/migrations/bootstrap-application-to-server-application/README.md
Outdated
Show resolved
Hide resolved
f93674e to
3615fd4
Compare
jkrems
approved these changes
Sep 4, 2025
josephperrott
approved these changes
Sep 4, 2025
| @@ -45,7 +50,7 @@ export class PlatformState { | |||
| export function provideServerRendering(): EnvironmentProviders; | |||
|
|
|||
| // @public | |||
| export function renderApplication<T>(bootstrap: () => Promise<ApplicationRef>, options: { | |||
| export function renderApplication(bootstrap: ReturnType<typeof bootstrapServerApplication>, options: { | |||
There was a problem hiding this comment.
Curious how would this be rendered on ADEV. As an option, we can introduce a new type here.
There was a problem hiding this comment.
It does render correctly. See: https://ng-dev-previews-fw--pr-angular-angular-63562-adev-prev-fbt65dr2.web.app/api/platform-server/renderApplication
Comment on lines
+5
to
7
| const bootstrap = bootstrapServerApplication(AppComponent, config); | ||
|
|
||
| export default bootstrap; |
There was a problem hiding this comment.
For the generated code, can we just do this or it's better to have a const?
export default bootstrapServerApplication(AppComponent, config);
There was a problem hiding this comment.
Yeah we can, although I did not change it in the existing code.
This commit introduces a number of changes to the server bootstrapping process to make it more robust and less error-prone, especially for concurrent requests. Previously, the server rendering process relied on a module-level global platform injector. This could lead to issues in server-side rendering environments where multiple requests are processed concurrently, as they could inadvertently share or overwrite the global injector state. To address this, the bootstrapping process now explicitly passes the `platformInjector` through the `bootstrapServerApplication` and `renderApplication` functions. This ensures that each server-side render has its own isolated platform injector, preventing state leakage between requests. The `bootstrapApplication` function will now throw an error when used on the server. Instead, developers should use the newly introduced `bootstrapServerApplication` function from `@angular/platform-server`. In addition, `getPlatform()` and `destroyPlatform()` will now return `null` and be a no-op respectively when running in a server environment. BREAKING CHANGE: - `bootstrapApplication` can no longer be used on the server. Instead, `bootstrapServerApplication` from `@angular/platform-server` should be used. - `renderApplication` now requires the return value of `bootstrapServerApplication`. - `getPlatform()` and `destroyPlatform()` are now no-ops on the server and `getPlatform()` will return `null`.
9dce5cf to
8dab173
Compare
|
Deployed adev-preview for 697d3a8 to: https://ng-dev-previews-fw--pr-angular-angular-63562-adev-prev-fbt65dr2.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
669792e to
697d3a8
Compare
697d3a8 to
4ce8bc6
Compare
4ce8bc6 to
ff571e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a number of changes to the server bootstrapping process to make it more robust and less error-prone, especially for concurrent requests.
Previously, the server rendering process relied on a module-level global platform injector. This could lead to issues in server-side rendering environments where multiple requests are processed concurrently, as they could inadvertently share or overwrite the global injector state.
To address this, the bootstrapping process now explicitly passes the
platformInjectorthrough thebootstrapServerApplicationandrenderApplicationfunctions. This ensures that each server-side render has its own isolated platform injector, preventing state leakage between requests.The
bootstrapApplicationfunction will now throw an error when used on the server. Instead, developers should use the newly introducedbootstrapServerApplicationfunction from@angular/platform-server.In addition,
getPlatform()anddestroyPlatform()will now returnnulland be a no-op respectively when running in a server environment.BREAKING CHANGE:
bootstrapApplicationcan no longer be used on the server. Instead,bootstrapServerApplicationfrom@angular/platform-servershould be used.renderApplicationnow requires the return value ofbootstrapServerApplication.getPlatform()anddestroyPlatform()are now no-ops on the server andgetPlatform()will returnnull.