refactor(@angular-devkit/core): additional isolated declarations cleanup #30208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
approved these changes
Apr 30, 2025
| } | ||
|
|
||
| export class SimpleMemoryHost implements Host<{}> { | ||
| protected _cache = new Map<Path, Stats<SimpleMemoryHostStats>>(); | ||
| protected _cache: Map<Path, Stats<SimpleMemoryHostStats>> = new Map(); | ||
| private _watchers = new Map<Path, [HostWatchOptions, Subject<HostWatchEvent>][]>(); |
There was a problem hiding this comment.
I assume this wasn't updated because it's private and won't show up in typings? Should we favor style consistency over the strict requirements (no strong preference either way, just wondering)?
There was a problem hiding this comment.
Yes, since that is private it's not an issue from an isolated declarations perspective.
Good question, though. For this PR, I went through each error and fixed individually. Since that was not an error, it was not modified. In general, I do favor consistency. However, we would probably need some form of lint check to both catch all these cases and prevent backsliding. This may be a good followup task.
To eventually support the use of the TypeScript `isolatedDeclarations` option, additional type adjustments have been made to code within the `@angular-devkit/core` package. While this is not yet comprehensive, it significantly reduces the amount of build errors with the `isolatedDeclarations` option enabled.
dbbe8c9 to
876ae1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To eventually support the use of the TypeScript
isolatedDeclarationsoption, additional type adjustments have been made to code within the@angular-devkit/corepackage. While this is not yet comprehensive, it significantly reduces the amount of build errors with theisolatedDeclarationsoption enabled.