Skip to content

fix(@angular-devkit/core): use more precise iterator typings #30269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented May 7, 2025

Since this class isn't a "real" Set, we can't promise that our iterators are true SetIterator<T>s.

Follow-up to #30226.

@jkrems jkrems requested a review from clydin May 7, 2025 14:59
@jkrems jkrems added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 7, 2025
@jkrems jkrems force-pushed the jk-no-set-iterator branch from a1be2ad to 4c41f22 Compare May 7, 2025 15:05
Since this class isn't a "real" `Set`, we can't promise that our
iterators are true `SetIterator<T>`s.
@jkrems jkrems force-pushed the jk-no-set-iterator branch from 4c41f22 to 8f917a1 Compare May 7, 2025 15:57
@jkrems jkrems added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 7, 2025
@clydin clydin merged commit 16ae68a into angular:main May 7, 2025
31 checks passed
@clydin
Copy link
Member

clydin commented May 7, 2025

The changes were merged into the following branches: main, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular-devkit/core target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants