Skip to content

fix(@schematics/angular): skip zone.js dependency for zoneless applications #30421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented May 29, 2025

A newly generated application no longer adds the zone.js dependency to the workspace if the zoneless option is enabled.

Closes #30419

@clydin clydin added the target: patch This PR is targeted for the next patch release label May 29, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 29, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break in the case a workspace is create without zone.js and a new library is created.

ng new --zoneless
ng g lib

…ations

A newly generated application no longer adds the `zone.js` dependency to
the workspace if the `zoneless` option is enabled.
@clydin clydin force-pushed the schematics/zoneless-zone-dep branch from c15214c to 05b4936 Compare June 3, 2025 11:39
@clydin clydin requested a review from alan-agius4 June 3, 2025 11:39
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 3, 2025
@clydin clydin merged commit 7ca250a into angular:main Jun 3, 2025
31 checks passed
@clydin
Copy link
Member Author

clydin commented Jun 3, 2025

The changes were merged into the following branches: main, 20.0.x

@clydin clydin deleted the schematics/zoneless-zone-dep branch June 3, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoneless option still include zone.js in the dependencies
2 participants