Skip to content

refactor(@angular/cli): separate MCP tool declaration assembly into helper function #30869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 11, 2025

The logic to assemble the list of active tools for the MCP server has been extracted into a new assembleToolDeclarations helper function. This improves the structure and readability of the createMcpServer function.

The tool lists have also been moved to module-level, readonly variables with JSDoc comments to improve clarity and prevent accidental modifications.

…elper function

The logic to assemble the list of active tools for the MCP server has been extracted into a new `assembleToolDeclarations` helper function. This improves the structure and readability of the `createMcpServer` function.

The tool lists have also been moved to module-level, `readonly` variables with JSDoc comments to improve clarity and prevent accidental modifications.
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Aug 11, 2025
@clydin clydin requested a review from alan-agius4 August 11, 2025 23:50
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 12, 2025
@alan-agius4 alan-agius4 merged commit 7327970 into angular:main Aug 12, 2025
32 of 33 checks passed
@clydin clydin deleted the mcp/declarative-registration branch August 12, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/cli target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants